Warn when compose wait strategy names don't match containers#1232
Merged
cristianrgreco merged 4 commits intomainfrom Feb 17, 2026
Merged
Warn when compose wait strategy names don't match containers#1232cristianrgreco merged 4 commits intomainfrom
cristianrgreco merged 4 commits intomainfrom
Conversation
cristianrgreco
added
bug
✅ Deploy Preview for testcontainers-node ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
cristianrgreco
added
enhancement
cristianrgreco
force-pushed
the
codex/issue-837-compose-wait-strategy-validation
branch
from
f7e1e0a to
f76a417
Compare
cristianrgreco
deleted the
codex/issue-837-compose-wait-strategy-validation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
DockerComposeEnvironment.up()whenwithWaitStrategy(...)names do not match any started containers..up([...])takes service names.withWaitStrategy(...)takes container names (for example<service>-1in Compose v2)Verification commands run
npm run formatnpm run lintnpm test -- packages/testcontainers/src/docker-compose-environment/docker-compose-environment.test.ts -t "should warn when no started containers match configured wait strategy names"Test results summary
1 passed, 24 skipped).Closes #837